Use the custom scanner to split ! from . #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, we've tolerated the parser treating `!.` as one operator when it should really be two. This changes that behavior so that we better match the actual semantics of `!.`, which is a bang-operator followed by navigation. We do this by adding `!` to the custom scanner, but this also requires us to generalize the custom scanner's operators and indicate that they are not all cross-semi operators. That's because `!` at the start of a line is valid (although it will usually result in a warning) - it gives us a standalone expression that negates what comes after the `!`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, we've tolerated the parser treating
!.as one operator when itshould really be two. This changes that behavior so that we better match
the actual semantics of
!., which is a bang-operator followed bynavigation.
We do this by adding
!to the custom scanner, but this also requiresus to generalize the custom scanner's operators and indicate that they
are not all cross-semi operators. That's because
!at the start of aline is valid (although it will usually result in a warning) - it gives
us a standalone expression that negates what comes after the
!.