Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payment integration via Stripe #672

Merged
merged 4 commits into from
Mar 9, 2020
Merged

Payment integration via Stripe #672

merged 4 commits into from
Mar 9, 2020

Conversation

casswarry0
Copy link

@casswarry0 casswarry0 commented Nov 14, 2019

My implementation is according to https://stripe.com/docs/payments/accept-a-payment
Don't forget to: composer require stripe/stripe-php

easyappointments.zip

PetrTodorov and others added 4 commits October 19, 2018 19:49
Fix get involved link
Fixing connection issues to MySQL 8.0.4.
Fixing connection issues to MySQL 8.0.4
@alextselegidis alextselegidis merged commit 0fe96a2 into develop Mar 9, 2020
@kaustubhk24
Copy link
Contributor

kaustubhk24 commented Jul 21, 2020

@casswarry0 Can you please give some details. How the stripe works with it?. Something like what to change in repo

@casswarry0
Copy link
Author

@kaustubhk24 The easyappointments.zip attached to the pull request contains all changed files. Additionally you have to do "composer require stripe/stripe-php" to include the Stripe API into the project. The file "config-sample.php" contains the new constants required for the Stripe integration. I hope this answers all your questions.

@kaustubhk24
Copy link
Contributor

@casswarry0 Thank you for your reply. I will check that.

@kaustubhk24
Copy link
Contributor

@casswarry0 I added files. But doesn't asks for any payments. directly books appointments

@casswarry0
Copy link
Author

@kaustubhk24 I assume you have a running instance of EasyAppointments and replaced the files with the files from the easyappointments.zip? Have you set "STRIPE_FEATURE = TRUE;" and also filled the 3 other STRIPE_ constants with values from your Stripe account (or with the generic test tokens) in the config.php? Have you created a task with a price set > 0 in EasyAppointments admin interface?

@kaustubhk24
Copy link
Contributor

@casswarry0 I will do that

@asyncopation
Copy link

Hi @casswarry0 @alextselegidis quick questions:

  1. This implementation was attached as a ZIP file instead of merged in the PR. Are there any plans to merge this implementation?
  2. Since this modifies code outside of src/vendor/stripe, what is your approach in keeping this up to date with the latest features and fixes from master, security updates, etc.

Appreciate any insight, thanks!

@casswarry0
Copy link
Author

Hi @asyncopation, I believe that the code was merged.

@alextselegidis
Copy link
Owner

Hello @casswarry0,

Thanks for the PR, I will review and let you know of my findings.

@asyncopation If merged then it will be done properly with composer.json updates etc.

Also just to make clear, before a new feature is merged I always make sure it it well tested and can be easily used by anyone, technical or non technical individuals.

  Alex Tselegidis, Easy!Appointments Creator
  Need a customization? Get a free quote!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants