Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): open closed panel on ArrowDown and ArrowUp #599

Merged
merged 5 commits into from
Jul 6, 2021

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Jun 1, 2021

Summary

With the input focused, pressing or should open the panel if it was previously closed.

Result

With openOnFocus: true or a query, and the input focused:

  • Pressing will open the panel with the input focused.
  • Pressing will open the panel with the last element of the list focused.

Reference: w3c aria practices
Closes #584

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 1, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bc45547:

Sandbox Source
@algolia/autocomplete-example-github-repositories-custom-plugin Configuration
@algolia/autocomplete-example-instantsearch Configuration
@algolia/autocomplete-example-playground Configuration
@algolia/autocomplete-example-preview-panel-in-modal Configuration
@algolia/autocomplete-example-react-renderer Configuration
@algolia/autocomplete-example-starter-algolia Configuration
@algolia/autocomplete-example-starter Configuration
@algolia/autocomplete-example-voice-search Configuration
@algolia/autocomplete-example-vue Configuration

@shortcuts shortcuts requested a review from Haroenv June 1, 2021 07:39
@francoischalifour
Copy link
Member

Putting "On Hold" because tests are not failing when they should (they're not run correctly).

Copy link
Member

@francoischalifour francoischalifour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@shortcuts shortcuts merged commit 37ebefe into next Jul 6, 2021
@shortcuts shortcuts deleted the fix/panel-accessibility branch July 6, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arrow Down key should open combobox popup
3 participants