Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

fix(autocomplete-css): use babel transpiling for places.css #887

Merged
merged 4 commits into from
Sep 30, 2019
Merged

fix(autocomplete-css): use babel transpiling for places.css #887

merged 4 commits into from
Sep 30, 2019

Conversation

JonathanMontane
Copy link
Contributor

@JonathanMontane JonathanMontane commented Sep 20, 2019 •
edited
Loading

Closes #886

Summary
Uses babel transpiler to inliine the css into the autocomplete file.

Result

npm run build
less dist/autocomplete.js # <- should have a css variable instead of a require

I am on vacation, so I'll let you release.

@JonathanMontane JonathanMontane self-assigned this Sep 20, 2019
raphi
raphi approved these changes Sep 20, 2019
View reviewed changes
Copy link
Contributor

@raphi raphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raphi raphi self-requested a review September 20, 2019 13:27
raphi
raphi suggested changes Sep 20, 2019
View reviewed changes
Copy link
Contributor

@raphi raphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is break autocompleteDataset with error module.exports is read only

@raphi
Copy link
Contributor

raphi commented Sep 26, 2019

Works now 👍

@JonathanMontane JonathanMontane merged commit fcc7112 into master Sep 30, 2019
@JonathanMontane JonathanMontane deleted the fix/autocomplete-css branch September 30, 2019 13:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@raphi raphi raphi approved these changes

Assignees

@JonathanMontane JonathanMontane

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(autocompleteDataset) places.css not found
2 participants
@JonathanMontane @raphi