This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 234
Option to disable most custom styling #91
Comments
BTW a specific build is not the good idea, removed it from the title |
vvo
changed the title
Option or build to disable most custom styling
Option to disable most custom styling
Apr 7, 2016
redox
added a commit
that referenced
this issue
Apr 8, 2016
Add a new `style: {input: boolean}` option to control whether the input should be styled or not. We might want to go further later by allowing to disable the menu styling as well. Fix #91
redox
added a commit
that referenced
this issue
Apr 13, 2016
Disable all <input /> border/shadow/padding styling, we want to fix the page styles. Add a new `style: boolean` option to control whether the input and dropdown menu should be styled or not. Fix #91
redox
added a commit
that referenced
this issue
Apr 13, 2016
Disable all <input /> border/shadow/padding styling, we want to fix the page styles. Add a new `style: boolean` option to control whether the input and dropdown menu should be styled or not. Fix #91
redox
added a commit
that referenced
this issue
Apr 13, 2016
Disable all <input /> border/shadow/padding styling, we want to fix the page styles. Add a new `style: boolean` option to control whether the input and dropdown menu should be styled or not. Fix #91
redox
added a commit
that referenced
this issue
Apr 13, 2016
Disable all <input /> border/shadow/padding styling, we want to fix the page styles. Add a new `style: boolean` option to control whether the input and dropdown menu should be styled or not. Fix #91
vvo
pushed a commit
that referenced
this issue
Apr 14, 2016
## [0.0.13](v0.0.12...v0.0.13) (2016-04-14) ### Bug Fixes * **administrative:** the `administrative` can be undefined (#99) ([ace575d](ace575d)) * **buttons:** avoid submit on click (#103) ([cae3676](cae3676)) * **footer:** small footer dropdown fixes ([e05ae3b](e05ae3b)) * **landing:** fix title font size on mobile (#108) ([7ab6051](7ab6051)), closes [(#108](https:/(/issues/108) * **svg:** always trim included svg files ([e013ce5](e013ce5)) * **website:** Change OSM icon on dropdown ([e575454](e575454)) * **website:** Change style for dropdown footer ([7ab2a14](7ab2a14)) ### Features * **agent:** add specific Algolia Places x.x.x agent sent ([d981fd6](d981fd6)) * **footer:** first built by draft ([dc75c8d](dc75c8d)) * **styling:** Change the way to styling is done ([d770d89](d770d89)), closes [#91](#91)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In order to easily integrate on an existing website with a lot of custom styling around inputs, we should be able to use places.js without the whole CSS places.js is injecting.
This would mean exposing an option to have a places.js without styling around borders, shadows, border-radius, paddings, margins.
Should we just load 0 CSS at all? Because if we start doing half CSS half no CSS then people might have a hard time removing the last bits.
Only issue about this are the icons, pin, clear and city icons both in the input and in the dropdown are stylised.
Otherwise, we will expose in a second step ways to override SVG icons.
Implentation wise, this would mean using the nice options on css.use() of our webpack style loader: https:/webpack/style-loader#reference-counted-api
We can split in:
I wonder if the default behavior should be to load the places.scss or to make it on demand. Maybe the later the better.
The text was updated successfully, but these errors were encountered: