This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
fix(errors): precise error messages on some bad usage #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| // if NodeList received, resolve to the first one | ||
| if (container instanceof NodeList) { |
There was a problem hiding this comment.
Probably best to merge that with the first test.
There was a problem hiding this comment.
Thanks. Done, let me know.
vvo
force-pushed
the
fix/error-on-multiple-containers
branch
from
f03f860
to
dc8f0e1
Compare
|
LGTM. Sorry I was not very awaken :D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warn when:
I don't think we need to support multiple DOM elements linked to a single instance of autocomplete.js, this looks like a edge case that is easily solvable user side (instantiate twice).
As for the underlying bug request (#229), it looks like the user do want to have multiple instances since those are different input purposes.