This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
fix(viaIP-conflict): disable aroundLatLngViaIP when setting location #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanMontane
force-pushed
the
fix/viaIP-conflict
branch
from
23e76f6
to
5216c21
Compare
samouss
previously approved these changes
Aug 8, 2018
samouss
previously requested changes
Aug 8, 2018
src/instantsearch/widget.js
Outdated
| @@ -36,6 +38,7 @@ class AlgoliaPlacesWidget { | |||
|
|
|||
| helper | |||
| .setQueryParameter('insideBoundingBox') | |||
| .setQueryParameter('aroundLatLngViaIP', false) | |||
There was a problem hiding this comment.
We probably need to implement this line inside getWidgetSearchParameters
|
We did some tests & changes with @raphi. I will push them because it's a bit tricky to explain. |
|
@samouss can we move forward on that point? |
|
Yep! Didn't have the time to take a look yet, I'll do it in the week. |
samouss
force-pushed
the
fix/viaIP-conflict
branch
from
5216c21
to
645a977
Compare
|
I don't have the rights to restart Netlify. |
samouss
force-pushed
the
fix/viaIP-conflict
branch
from
645a977
to
3cdcf6b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using the Places Widget in coordination with other geolocation widget such as the Geosearch, there can be a conflict between the
aroundLatLngViaIP:truefield and thearoundLatLngset by Places.Result
aroundLatLngViaIPis set tofalsewhen a user selects a geolocation through places. It is restored to its initial value on clear.