This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
fix(promise-polyfill): remove babel-polyfill and let babel do magic #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The polyfills we introduced to support IE11 created an issue with the usage of
Promise.finallydue to a bug in the way Babel checks for the polyfill usage: babel/babel#8297 (comment)This PR removes
@babel/polyfilland uses an alternative syntax for Object.assign that is automatically polyfilled by babel #magicResult
Search works and .finally works in Firefox and in IE11