Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[log parts enhance] Use env to control ilogtail log level #1096

Merged
merged 9 commits into from
Sep 5, 2023

Conversation

zhu733756
Copy link
Contributor

@zhu733756 zhu733756 commented Aug 28, 2023

fixes #959

dev steps:

  • follow the issue, and make this pr.

how to check it

  • use devcontainer to develop, follow the article here
  • export LOGTAIL_LOG_LEVEL=debug
  • ./ilogtail &
  • see the log prints like below:
read log level from the env successfully, level: debug
Load log config from /root/go/src/github.com/ilogtail/core/build/apsara_log_conf.json
Logger size in config: 4
Path of logger named /: /workspaces/ilogtail/core/build/ilogtail.LOG
logger named / created.
Path of logger named /apsara/sls/ilogtail: /workspaces/ilogtail/core/build/ilogtail.LOG
logger named /apsara/sls/ilogtail created.
Path of logger named /apsara/sls/ilogtail/profile: /workspaces/ilogtail/core/build/snapshot/ilogtail_profile.LOG
logger named /apsara/sls/ilogtail/profile created.
Path of logger named /apsara/sls/ilogtail/status: /workspaces/ilogtail/core/build/snapshot/ilogtail_status.LOG
logger named /apsara/sls/ilogtail/status created.

dalaos look here

Hi dalaos, I am a new comer for cpp developer, if this pr has any problem to run, please corret me, thanks in advance!

@CLAassistant
Copy link

CLAassistant commented Aug 28, 2023

CLA assistant check
All committers have signed the CLA.

core/logger/Logger.h Outdated Show resolved Hide resolved
core/logger/Logger.cpp Outdated Show resolved Hide resolved
core/logger/Logger.cpp Outdated Show resolved Hide resolved
core/logger/Logger.cpp Outdated Show resolved Hide resolved
core/logger/Logger.cpp Outdated Show resolved Hide resolved
core/logger/Logger.cpp Outdated Show resolved Hide resolved
core/logger/Logger.cpp Show resolved Hide resolved
core/logger/Logger.cpp Outdated Show resolved Hide resolved
core/logger/Logger.cpp Outdated Show resolved Hide resolved
core/logger/Logger.cpp Outdated Show resolved Hide resolved
core/logger/Logger.cpp Outdated Show resolved Hide resolved
core/logger/Logger.h Outdated Show resolved Hide resolved
Signed-off-by: zhuhan <[email protected]>
Signed-off-by: zhuhan <[email protected]>
core/logger/Logger.cpp Outdated Show resolved Hide resolved
core/logger/Logger.cpp Outdated Show resolved Hide resolved
pkg/logger/logger.go Outdated Show resolved Hide resolved
pkg/logger/logger.go Outdated Show resolved Hide resolved
pkg/logger/logger.go Outdated Show resolved Hide resolved
pkg/logger/logger_test.go Outdated Show resolved Hide resolved
@yyuuttaaoo
Copy link
Collaborator

There will be a dev meeting next week, would you like to join us and introduce your work?
see #1084

@zhu733756
Copy link
Contributor Author

zhu733756 commented Aug 30, 2023

There will be a dev meeting next week, would you like to join us and introduce your work? see #1084

Thanks, It's my pleasure, I will attend this meeting if I have the time

Signed-off-by: zhuhan <[email protected]>
@yyuuttaaoo
Copy link
Collaborator

yyuuttaaoo commented Sep 1, 2023

Please add a change log line in CHANGLOG.md and help to add a doc to clarify the new env you've added here. https:/alibaba/ilogtail/blob/main/docs/cn/configuration/system-config.md

@zhu733756
Copy link
Contributor Author

Please add a change log line in CHANGLOG.md and help to add a doc to clarify the new env you've added here. https:/alibaba/ilogtail/blob/main/docs/cn/configuration/system-config.md

done

@yyuuttaaoo
Copy link
Collaborator

Can you tell me how to contract you on DingTalk?
If you are using iLogtail in you company, may you record you use case here? #693

@zhu733756
Copy link
Contributor Author

zhu733756 commented Sep 4, 2023

Can you tell me how to contract you on DingTalk? If you are using iLogtail in you company, may you record you use case here? #693

  • My DingTalk name is 朱晗,I have joned the ilogtail社区 community
  • I‘m sorry for that I am not responsible for observability development in the company. I am a cloud database development engineer. Personally, I am interested in both this project and observability projects. I would like to participate in open-source projects to enhance my skills. If possible, I will recommend it to them.

@yyuuttaaoo yyuuttaaoo merged commit 362b0a0 into alibaba:main Sep 5, 2023
20 checks passed
@yyuuttaaoo yyuuttaaoo added this to the v1.8 milestone Sep 26, 2023
@yyuuttaaoo yyuuttaaoo added the feature request New feature request label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT]: Use env to control ilogtail log level
4 participants