fix: reset checkpoint dump time after dir registration completes to avoid log duplication #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messixukejia
approved these changes
Dec 28, 2023
yyuuttaaoo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For file log collection, if watched dirs are in NFS, chances are it will take long to complete dir registration. Since current checkpoint dump time is reset before dir registration, and checkpoint dump period is set to 1 min in k8s, chances are checkpoints are dumped and cleared immediately after dir registration with NFS, right before log reader status can be recovered from checkpoints, which finally leads to log duplication.
Therefore, we should reset dump time after dir registration.