Fix microsecond handling in Apsara log parser #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parser previously used microsecond incorrectly in the time cache. Now only the time in second is properly retrieved from the cache. And the microsecond part is always parsed from log timestamps. Additionally, a bounds check has been added to prevent out-of-range array access, ensuring reliable operation.
henryzhx8
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser previously used microsecond incorrectly in the time cache. Now only the time in second is properly retrieved from the cache. And the microsecond part is always parsed from log timestamps.
Additionally, a bounds check has been added to prevent out-of-range array access, ensuring reliable operation.