fix core caused by concurrent use of non-thread-safe gethostbyname #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messixukejia
requested changes
Jul 12, 2024
core/common/MachineInfoUtil.cpp
Outdated
| #endif | ||
| if (i == 0) { | ||
| firstIp = tmp; | ||
| #if defined(__linux__) |
There was a problem hiding this comment.
宏的嵌套比之前复杂了很多，感觉还是之前linux windows整体分开更清晰些，虽然会多一些外围的循环。
There was a problem hiding this comment.
1、windows是怎么测试的
2、这个问题自己是否能复现，并发是怎么测试的
There was a problem hiding this comment.
- windows目前没有测试，会记一个todo等windows那边能编译后再测试
- yitao的机器在特定输入下有大概率复现，lingzhu之前的dns core问题目前看也是这个导致的，两个场景可以复现。代码修复后多次运行没有再出现core。
yyuuttaaoo
approved these changes
Jul 15, 2024
messixukejia
approved these changes
Jul 18, 2024
Abingcbc
added a commit
to Abingcbc/ilogtail
that referenced
this pull request
Jul 19, 2024
commit c8385ca Author: henryzhx8 <[email protected]> Date: Fri Jul 19 09:42:31 2024 +0800 fix core caused by concurrent use of non-thread-safe gethostbyname (alibaba#1611) * fix core caused by concurrent use of non-thread-safe gethostbyname commit 8fc252e Author: Qiu Fengshuo <[email protected]> Date: Thu Jul 18 09:42:06 2024 +0800 speedup CI UT job (alibaba#1606) * Split the original UT CI job into two separate jobs: one with SPL and one without SPL * fix: change design. Build .a and .so at the same CI UT job * fix * fix * fix * fix * fix * fix * fix
linrunqi08
pushed a commit
that referenced
this pull request
Jul 23, 2024
…1611) * fix core caused by concurrent use of non-thread-safe gethostbyname
linrunqi08
pushed a commit
that referenced
this pull request
Aug 27, 2024
…1611) * fix core caused by concurrent use of non-thread-safe gethostbyname
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
排查下来大概率是由于定时检查ip变没变时调用的非可重入版本gethostbyname，与同步发送时curl使用的gethostbyname函数发生了data race。