Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Optimization] In com.alibaba.nacos.core.auth.AuthConfig #10020

Closed
ZhangShenao opened this issue Feb 28, 2023 · 0 comments
Closed

[Code Optimization] In com.alibaba.nacos.core.auth.AuthConfig #10020

ZhangShenao opened this issue Feb 28, 2023 · 0 comments

Comments

@ZhangShenao
Copy link
Contributor

Is it better to use generic type when declaring authFilterRegistration? Just like FilterRegistrationBean<AuthFilter>.

KomachiSion pushed a commit that referenced this issue Mar 2, 2023
…n` in com.alibaba.nacos.core.auth.AuthConfig (#10021)

* code optimization for `ConfigChangeHandler`

* [ISSUE #9930] fix word spelling error in com.alibaba.nacos.common.http.AbstractHttpClientFactory#ASYNC_IO_REACTOR_NAME

* [ISSUE #10020] Use Generic Type When Declaring `authFilterRegistration` in com.alibaba.nacos.core.auth.AuthConfig

* fix code format

* fix code format

* Fix Code Format

* Fix Code Format
KomachiSion pushed a commit that referenced this issue Apr 13, 2023
* code optimization for `ConfigChangeHandler`

* [ISSUE #9930] fix word spelling error in com.alibaba.nacos.common.http.AbstractHttpClientFactory#ASYNC_IO_REACTOR_NAME

* [ISSUE #10020] Use Generic Type When Declaring `authFilterRegistration` in com.alibaba.nacos.core.auth.AuthConfig

* fix code format

* fix code format

* Fix Code Format

* Fix Code Format

* [ISSUE #10308] Use Generic Type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants