Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logback.xml Incorrect configuration #11793

Closed
heihei180 opened this issue Mar 4, 2024 · 2 comments
Closed

logback.xml Incorrect configuration #11793

heihei180 opened this issue Mar 4, 2024 · 2 comments
Labels
kind/enhancement Category issues or prs related to enhancement.

Comments

@heihei180
Copy link
Contributor

heihei180 commented Mar 4, 2024

Describe the bug
this file example/src/main/resources/logback.xml config the log file path is error.

line 23 and line 26.
like this:

        <file>/Users/xiweng.yy/logs/nacos/perf.log</file>
        
        <rollingPolicy class="ch.qos.logback.core.rolling.FixedWindowRollingPolicy">
            <fileNamePattern>/Users/xiweng.yy/logs/nacos/perf.log.%i</fileNamePattern>
            <maxIndex>${JM.LOG.RETAIN.COUNT:-7}</maxIndex>
        </rollingPolicy>

i think should use

        <file>${user.home}/logs/nacos/perf.log</file>
        
        <rollingPolicy class="ch.qos.logback.core.rolling.FixedWindowRollingPolicy">
            <fileNamePattern>${user.home}/logs/nacos/perf.log.%i</fileNamePattern>
            <maxIndex>${JM.LOG.RETAIN.COUNT:-7}</maxIndex>
        </rollingPolicy>

Expected behavior
modify the log file 's path.

Actually behavior
use /Users/xiweng.yy/logs/nacos/ , but i'm not xiweng.yy

How to Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See errors

Desktop (please complete the following information):

  • OS: [e.g. Centos] : ubuntu
  • Version [e.g. nacos-server 1.3.1, nacos-client 1.3.1] : dev
  • Module [e.g. naming/config]: example
  • SDK [e.g. original, spring-cloud-alibaba-nacos, dubbo]: original

Additional context
Add any other context about the problem here.

I have reported this incorrect configuration before, but I made a mistake apache/rocketmq#7879

@KomachiSion
Copy link
Collaborator

Welcome PR

@KomachiSion KomachiSion added the kind/enhancement Category issues or prs related to enhancement. label Mar 4, 2024
@heihei180
Copy link
Contributor Author

Welcome PR

ok, i will modify it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants