Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log output sensitive information #12547

Closed
hecter-java-architect opened this issue Aug 23, 2024 · 0 comments · Fixed by #12578
Closed

Log output sensitive information #12547

hecter-java-architect opened this issue Aug 23, 2024 · 0 comments · Fixed by #12578
Labels
area/Client Related to Nacos Client SDK kind/enhancement Category issues or prs related to enhancement.
Milestone
2.4.2

Comments

@hecter-java-architect
Copy link

Is your feature request related to a problem? Please describe.
In Nacos-Client, when an exception is thrown, the account password will also be exposed in the log.
com.alibaba.nacos.client.auth.impl.process.HttpLoginProcessor
image
Printing the password in the log is obviously not wise!

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
Block this type of log output

Additional context
Add any other context or screenshots about the feature request here.
@KomachiSion KomachiSion added kind/enhancement Category issues or prs related to enhancement. area/Client Related to Nacos Client SDK labels Aug 28, 2024
@KomachiSion KomachiSion added this to the 2.4.2 milestone Aug 28, 2024
KomachiSion added a commit to KomachiSion/nacos that referenced this issue Sep 2, 2024
@KomachiSion
For alibaba#12547, nacos client supports desensitise in logging.
f162375
@KomachiSion KomachiSion mentioned this issue Sep 2, 2024
Merged
5 tasks
KomachiSion added a commit that referenced this issue Sep 2, 2024
@KomachiSion
For #12547, nacos client supports desensitise in logging. (#12578)
98a6e22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/Client Related to Nacos Client SDK kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
2.4.2
Development

Successfully merging a pull request may close this issue.

[ISSUE#12547] nacos client supports desensitise in logging. KomachiSion/nacos
2 participants
@KomachiSion @hecter-java-architect