Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common classes in Nacos should be unified #2025

Closed
nkorange opened this issue Nov 7, 2019 · 2 comments · Fixed by #2086
Closed

Common classes in Nacos should be unified #2025

nkorange opened this issue Nov 7, 2019 · 2 comments · Fixed by #2086
Labels
contribution welcome kind/code quality

Comments

@nkorange
Copy link
Collaborator

nkorange commented Nov 7, 2019 •
edited
Loading

Currently there are several HttpClient classes in Nacos, they should be merged to one class. So we can avoid repeated changes like in #2018
@nkorange nkorange changed the title HttpClient in Nacos should be unified Common classes in Nacos should be unified Nov 7, 2019
@nkorange
Copy link
Collaborator Author

nkorange commented Nov 7, 2019

Actually there are more than one kind of classes should be unified. Some of the candidates are:

  • HttpClient
  • IOUtils
  • StringUtils
  • ...

@haochencheng
Copy link

Actually there are more than one kind of classes should be unified. Some of the candidates are:

  • HttpClient
  • IOUtils
  • StringUtils
  • ...

i create a pull request to unified IOUtils and StringUtils
the branch name is haochencheng:feature/unifiedCommonClasses
how should i do to finished this pull request

@huangdx0726 huangdx0726 mentioned this issue Nov 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribution welcome kind/code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Issues 2025] Common classes in Nacos should be unified huangdx0726/nacos
2 participants
@nkorange @haochencheng