Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming client http read timeout and connect timeout controlled by the same property #2577

Closed
FinalVersion opened this issue Apr 2, 2020 · 1 comment
Closed

Naming client http read timeout and connect timeout controlled by the same property #2577

FinalVersion opened this issue Apr 2, 2020 · 1 comment
Labels
contribution welcome kind/enhancement Category issues or prs related to enhancement.

Comments

@FinalVersion
Copy link

Issue Description

Currently, both com.alibaba.nacos.client.naming.net.HttpClient#TIME_OUT_MILLIS and com.alibaba.nacos.client.naming.net.HttpClient#CON_TIME_OUT_MILLIS are read from com.alibaba.nacos.client.naming.ctimeout system property.

There should be 2 system properties, one for each timeout parameter.

Type: bug report
@chuntaojun chuntaojun added kind/enhancement Category issues or prs related to enhancement. help wanted Extra attention is needed contribution welcome and removed help wanted Extra attention is needed labels Apr 3, 2020
@wolfgangzhu
Copy link
Contributor

one for read time out (com.alibaba.nacos.client.naming.rtimeout),
one for connection time out(com.alibaba.nacos.client.naming.ctimeout)
@i will solve it@

@wolfgangzhu wolfgangzhu mentioned this issue Apr 4, 2020
Merged
5 tasks
@yanlinly yanlinly mentioned this issue May 15, 2020
Merged
5 tasks
@yanlinly yanlinly mentioned this issue Jun 5, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribution welcome kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@FinalVersion @chuntaojun @wolfgangzhu