Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the original Notify implementation in the nacos's other modules. #3179

Closed
zongtanghu opened this issue Jun 25, 2020 · 3 comments
Closed

Comments

@zongtanghu
Copy link
Collaborator

zongtanghu commented Jun 25, 2020

Issue Description
Type: feature request

Describe what happened (or what feature you want)

(1)Replace the original Notify implementation in the core module and which is called places in other module;
And this pr is one part of another bigger pr.The link is #2859.

Describe what you expected to happen:

How to reproduce it (as minimally and precisely as possible):
1.
2.
3.

Tell us your environment:

Anything else we need to know?

@zongtanghu
Copy link
Collaborator Author

zongtanghu commented Jun 28, 2020

This feature issue has been split into serveral pr:
(1)The first pr link is(#3187), and this is to remove original Notify unit test cases' codes which has already been moved to common module, and fix some typo;
(2)The second pr link is(#3305), replace the NotifyCenter with new refactor in the and test module.
(3)The third pr link is(#3309) ,replace the original Notify implementation in the core/naming module;
(4)The fourth pr link is(#3310 ), delete original NotifyCenter codes in the core module.

KomachiSion pushed a commit that referenced this issue Jun 28, 2020
…unit test in test module (#3187)

* [#3141]fix Notify's typos in common module and remove NotifyCenter's unit test in test module.

* [#3141]fix variable naming issue.
@zongtanghu
Copy link
Collaborator Author

All task has already been done! @KomachiSion

@zongtanghu
Copy link
Collaborator Author

So I close this issue.

@KomachiSion KomachiSion mentioned this issue Aug 4, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants