Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor for naming sdk. #3386

Closed
4 tasks done
KomachiSion opened this issue Jul 20, 2020 · 0 comments
Closed
4 tasks done

Refactor for naming sdk. #3386

KomachiSion opened this issue Jul 20, 2020 · 0 comments
Assignees
@KomachiSion
Labels
area/Naming kind/refactor
Milestone
2.0.0

Comments

@KomachiSion
Copy link
Collaborator

KomachiSion commented Jul 20, 2020 •
edited
Loading

Issue Description

Type: refactor

Describe what happened (or what feature you want)

I'm implementing for #1097 to support grpc in branch feature_support_grpc_core. But I found the naming sdk is hard to inject gRPC because its components are highly coupled.

So I want to refactor them first make them decoupling simply.

  1. Currently, server list is maintained by httpServerProxy. I think it's the first point to extract server list maintainer out from httpServerProxy as a top component.
  2. BeatReactor is a http accessory, but now is as a top component and saved by HostReactor. I think is't the second point to refactor.
  3. Abstract one ClientProxy interface and implement http, grpc and other type may be better.

Describe what you expected to happen

  • Extract a ServerListManager like config sdk.
  • Abstract one ClientProxy and refactor ServerProxy as an implementation.
  • Move BeatReactor into HttpClientProxy
  • Refactor HostReactor
@KomachiSion KomachiSion self-assigned this Jul 20, 2020
@KomachiSion KomachiSion added this to the 1.4.0 milestone Jul 20, 2020
@KomachiSion KomachiSion mentioned this issue Jul 20, 2020
Merged
5 tasks
KomachiSion added a commit that referenced this issue Jul 20, 2020
@KomachiSion
[ISSUE #3386] Extract NamingClientProxy Interface (#3387)
39986a8 
* Move and rename NamingProxy.java

* rename package naming.net --> naming.remote

* Create Naming client proxy interface
This was referenced Jul 20, 2020
Merged
Merged
Merged
KomachiSion added a commit that referenced this issue Jul 21, 2020
@KomachiSion
[ISSUE #3386] Refactor HostReactor.java to ServiceInfoHolder and Serv…
115c992 
…iceInfoUpdateService (#3402)

* Refactor HostReactor.java to ServiceInfoHolder and ServiceInfoUpdateService

* Use http client as default implement of some uncompleted api
@KomachiSion KomachiSion modified the milestones: 1.4.0, 2.0.0 Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KomachiSion KomachiSion

Labels
area/Naming kind/refactor
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@KomachiSion