Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The server address server mode cannot obtain the application.properties Variables in( address.server.domain=xxx . xxx.com ) #3509

Closed
qm012 opened this issue Aug 4, 2020 · 3 comments
Assignees
Labels
contribution welcome kind/enhancement Category issues or prs related to enhancement.
Milestone

Comments

@qm012
Copy link
Contributor

qm012 commented Aug 4, 2020

Describe the bug
中文:服务端 address-server 模式无法获取从application.properties中的变量(address.server.domain=xxx.xxx.com)
英文:The server address server mode cannot obtain the application.properties Variables in( address.server.domain=xxx . xxx.com )

Expected behavior
中文:可以从配置文件中获取到系统变量, 当前的方式是 系统变量和启动jvm中获取, 也应该支持从配置文件中获取. 并且增加文档描述
获取配置的优先级:系统环境变量 -> 启动jvm(-D) -> properties
英文: the system variables can be obtained from the configuration file. The current way is to obtain the system variables from the system variables and the startup JVM. It should also support obtaining system variables from the configuration files.And add document description
Get the priority of configuration: system environment variables > start JVM (- D) - > properties

Acutally behavior
A clear and concise description of what you actually to happen.

How to Reproduce

  1. application.properties配置 address.server.domain=xxx.xxx.com
  2. 启动 debug: address.server.domain= null

4612C75B-D12A-466a-85B4-931B7ABD043B

Desktop (please complete the following information):

  • OS: windows
  • Version nacos-server 1.3.1
@qm012
Copy link
Contributor Author

qm012 commented Aug 4, 2020

If this needs to be addressed,@i will solve it@

@KomachiSion KomachiSion added kind/bug Category issues or prs related to bug. contribution welcome labels Aug 4, 2020
@KomachiSion
Copy link
Collaborator

Welcome to contribute. Thanks

@KomachiSion
Copy link
Collaborator

@chuntaojun What‘s your design? Can it be set by users?

qm012 pushed a commit to qm012/nacos that referenced this issue Aug 4, 2020
@KomachiSion KomachiSion added kind/enhancement Category issues or prs related to enhancement. and removed kind/bug Category issues or prs related to bug. labels Aug 5, 2020
@KomachiSion KomachiSion added this to the 1.4.0 milestone Aug 5, 2020
KomachiSion pushed a commit that referenced this issue Aug 5, 2020
…ties (#3516)

* Fix address server mode cannot be obtained application.properties And synchronize the properties value(#3509)

* format code.

* update mysql default value nacos:nacos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

No branches or pull requests

3 participants