-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.x,1.x EncryptedData bug in client. #7039
Comments
@robberphex 要不讨论一下,这个这个场景是否没有验证到;会造成
|
…ta not right content bug.
…ta not right content bug.
这里还会有一个 bug,因为 @Override
public String getConfigAndSignListener(String dataId, String group, long timeoutMs, Listener listener)
throws NacosException {
String content = getConfig(dataId, group, timeoutMs);
worker.addTenantListenersWithContent(dataId, group, content, Arrays.asList(listener));
return content;
} |
@li-xiao-shuang 哈哈,2.x 这部分加解密要不要统一看下 |
1.x 服务端没有适配加解密,加解密只在 > 2.0.3 做了 |
如果你要使用配置加解密 建议就使用2.x 的版本,如果 2.x 的有什么bug可以一起解决下 |
@li-xiao-shuang 没事哈,我内部都定制了,所以知道客户端有些 bug ,才提的 issue 和 PR |
客户端这块 2.x 我有空在详细看看 |
@ ready to close @ 2.x fix in #8463 , 1.4.x encrypted imperfect, so no need to deal with. 2.x 已修复,1.4.x 配置加密并不完善,故无需处理。 |
Describe the bug
relate [ISSUE #5367]SPI IConfigFilter (#5369)
1.4.2 Implementation of IConfigFilter spi configuration decryption, there is a problem when CacheData maintains the content and md5 values, the maintenance is encrypted content, and md5 is obtained from the decrypted content; because CacheData.md5 is wrong, every time checkUpdateDataIds will get changedGroupKeys, thus continuously GetServerConfig after listening. For details, please see LongPollingRunnable.
1.4.2 实现 IConfigFilter spi 配置解密,在 CacheData 维护 content 和 md5 值时有问题,维护的为加密内容,且md5从解密内容得到;因 CacheData.md5 不对,所以每次 checkUpdateDataIds 都会得到 changedGroupKeys,从而不断地进行 listening 后 getServerConfig。具体情况请看 LongPollingRunnable
Expected behavior
CacheData cache decryptContent and decryptContent's md5.
Acutally behavior
CacheData cache encryptedContent and encryptedContent's md5.
The text was updated successfully, but these errors were encountered: