-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.x client still requests to the server after calling unsubscribe() #7925
Labels
Comments
5 tasks
5 tasks
gaofeihang
added a commit
to gaofeihang/nacos
that referenced
this issue
Apr 11, 2022
KomachiSion
pushed a commit
that referenced
this issue
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
1.x client still requests to the server after calling unsubscribe(). The UpdateTask in HostReactor has no way to be stopped.
Expected behavior
After calling unsubscribe() and removing all listeners, the client stops to request to the server and stops to poll
/nacos/v1/ns/instance/list
. This expected behavior can reduce the QPS and the pressure of the Nacos server in some cases.Acutally behavior
After calling unsubscribe(), the client is still polling the server. UpdateTask is scheduled in a finally block in the run() method. It can never be stopped.
How to Reproduce
Steps to reproduce the behavior:
/nacos/v1/ns/instance/list
still exist.Desktop (please complete the following information):
Additional context
Codes for reproducing the problem.
The text was updated successfully, but these errors were encountered: