Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nacos1.4删除命名空间，命名空间下的数据删不掉 #8602

Closed
riane2 opened this issue Jun 21, 2022 · 6 comments · Fixed by #8609
Closed

nacos1.4删除命名空间，命名空间下的数据删不掉 #8602

riane2 opened this issue Jun 21, 2022 · 6 comments · Fixed by #8609
Labels
kind/enhancement Category issues or prs related to enhancement. status/need discuss

Comments

@riane2
Copy link

riane2 commented Jun 21, 2022

Describe the bug
nacos1.4删除命名空间，命名空间下的数据删不掉，配置页面和注册页面进去，数据都存在

Expected behavior
期望：命名空间下有数据时，要么提示用户不可删除，要么全部全量删除数据，否则会有垃圾数据

Actually behavior
所有命名空间下的数据都存在

How to Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See errors

Desktop (please complete the following information):

  • OS: [e.g. Centos]
  • Version [e.g. nacos-server 1.3.1, nacos-client 1.3.1]
  • Module [e.g. naming/config]
  • SDK [e.g. original, spring-cloud-alibaba-nacos, dubbo]

Additional context
Add any other context about the problem here.
@onewe
Copy link
Collaborator

onewe commented Jun 21, 2022

版本是1.4.0 吗？

@riane2
Copy link
Author

riane2 commented Jun 21, 2022

版本是1.4.0 吗？

1.4.1 版本

@onewe
Copy link
Collaborator

onewe commented Jun 21, 2022

我复现了, 这应该是前端的bug
@i will resolve it@

@riane2
Copy link
Author

riane2 commented Jun 21, 2022

我复现了, 这应该是前端的bug @i will resolve it@

后端数据库数据也没有删掉
还有请教一下：这种删除命名空间的操作有没有限制 ？比如说有服务注册在上面或者命名空间下有配置文件的时候不允许删除

@onewe
Copy link
Collaborator

onewe commented Jun 21, 2022

目前来看没有做限制

onewe added a commit to onewe/nacos that referenced this issue Jun 22, 2022
@onewe
[ISSUE alibaba#8602] fix display error after delete current namespace
2aa0b82 
- fix some warnings, such as use rowProps instead of getRowProps etc
- MainLayout keeps namespace param

Close alibaba#8602
@onewe onewe mentioned this issue Jun 22, 2022
Merged
5 tasks
@KomachiSion
Copy link
Collaborator

删除命名空间只是删空间，不会删除里面的数据， 这块确实考虑加一下校验，如果有内容不让删。

@KomachiSion KomachiSion added status/need discuss kind/enhancement Category issues or prs related to enhancement. labels Jun 24, 2022
KomachiSion pushed a commit that referenced this issue Jun 24, 2022
@onewe
[ISSUE #8602] fix display error after delete current namespace (#8609)
29b2fa4 
- fix some warnings, such as use rowProps instead of getRowProps etc
- MainLayout keeps namespace param

Close #8602
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Category issues or prs related to enhancement. status/need discuss
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #8602] fix display error after delete current namespace onewe/nacos
3 participants
@KomachiSion @onewe @riane2