Expose way to add config filter #10236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #10236 +/- ##
=============================================
+ Coverage 51.80% 51.83% +0.03%
- Complexity 5079 5094 +15
=============================================
Files 873 874 +1
Lines 27731 27776 +45
Branches 3071 3077 +6
=============================================
+ Hits 14365 14398 +33
- Misses 12040 12050 +10
- Partials 1326 1328 +2
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
KomachiSion
requested changes
Mar 31, 2023
| * It is recommended to use {@link com.alibaba.nacos.api.config.filter.AbstractConfigFilter} to expand the filter. | ||
| * | ||
| * @param configFilter filter | ||
| */ |
There was a problem hiding this comment.
Add since comment to show when the api start to support.
There was a problem hiding this comment.
maybe 2.3.0, the 2.2.1 has released and not include the api.
KomachiSion
requested changes
Apr 3, 2023
| * It is recommended to use {@link com.alibaba.nacos.api.config.filter.AbstractConfigFilter} to expand the filter. | ||
| * | ||
| * @param configFilter filter | ||
| */ |
There was a problem hiding this comment.
maybe 2.3.0, the 2.2.1 has released and not include the api.
KomachiSion
approved these changes
Apr 6, 2023
KomachiSion
added
kind/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
#10235
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.