Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #10271] Fix failover file path. #10272

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

YunWZ
Copy link
Contributor

@YunWZ YunWZ commented Apr 6, 2023

Failover file path should be like {user.home}/naming/{group}/failover/00-00---000-VIPSRV_FAILOVER_SWITCH-000---00-00.

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

…r/00-00---000-VIPSRV_FAILOVER_SWITCH-000---00-00`.
@codecov-commenter
Copy link

Codecov Report

Merging #10272 (b1846c7) into develop (dcb1017) will increase coverage by 0.08%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #10272      +/-   ##
=============================================
+ Coverage      52.32%   52.40%   +0.08%     
+ Complexity      5171     5170       -1     
=============================================
  Files            874      874              
  Lines          27757    27757              
  Branches        3073     3073              
=============================================
+ Hits           14524    14547      +23     
+ Misses         11910    11887      -23     
  Partials        1323     1323              
Impacted Files Coverage Δ
...a/nacos/client/naming/backups/FailoverReactor.java 39.66% <0.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcb1017...b1846c7. Read the comment docs.

@KomachiSion KomachiSion linked an issue Apr 6, 2023 that may be closed by this pull request
@KomachiSion KomachiSion added kind/bug Category issues or prs related to bug. area/Client Related to Nacos Client SDK labels Apr 6, 2023
@KomachiSion KomachiSion added this to the 2.3.0 milestone Apr 6, 2023
@KomachiSion KomachiSion merged commit 06a2ea7 into alibaba:develop Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Client Related to Nacos Client SDK kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nacos-client failover switch file path is incorrect。
3 participants