Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the GC as the CMS when jdk version less 9. #10343

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

aloneboat
Copy link
Contributor

@aloneboat aloneboat commented Apr 19, 2023

What is the purpose of the change

When Jdk version less than 9 , for example 8, the GC default is Parallel GC,the application threads will be pause for long time (as I understand it) ,that is not we want。
I find this change Support JDK 11,recovered some code

Brief changelog

Specify the GC as the CMS when jdk version less that 9.

@CLAassistant
Copy link

CLAassistant commented Apr 19, 2023

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

Merging #10343 (a02dc6d) into develop (bbf1bd8) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #10343      +/-   ##
=============================================
+ Coverage      54.31%   54.32%   +0.01%     
- Complexity      5435     5438       +3     
=============================================
  Files            879      879              
  Lines          27832    27832              
  Branches        3083     3083              
=============================================
+ Hits           15117    15121       +4     
+ Misses         11391    11386       -5     
- Partials        1324     1325       +1     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbf1bd8...a02dc6d. Read the comment docs.

@KomachiSion KomachiSion added this to the 2.3.0 milestone Apr 21, 2023
@KomachiSion KomachiSion merged commit ce371be into alibaba:develop Apr 21, 2023
@aloneboat aloneboat deleted the develop#214 branch April 21, 2023 05:02
@iJIAJIA
Copy link

iJIAJIA commented May 24, 2023

看了下gc配置, 有个疑惑点想讨论下, 这里为什么去除 -XX:-UseParNewGC. 我这边8c20g的3节点集群,跟默认使用UseParNewGC进行了3000的并发心跳压测对比, 吞吐量有10k左右的差距. 同时gc的频率也有差距.
启动时jvm也给了警告. 不推荐 cms 跟DefNew 搭配使用.

@iJIAJIA
Copy link

iJIAJIA commented May 24, 2023

image
image
对比下来, cms + ParNewGC的gc频次是远低于 cms + DefNew 的

@iJIAJIA
Copy link

iJIAJIA commented Jun 12, 2023

@aloneboat

@aloneboat
Copy link
Contributor Author

aloneboat commented Jun 12, 2023

@iJIAJIA Sorry for the late reply. you should be right, I just restored the earlier code,the purpose is simply to use the CMS garbage collector when jdk version less than 9, I didn't look closely at whether it was a plus or a minus before "ParNewGC",actually I agree with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants