Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageHandlerAdapterFactory, handlerAdapters,handlerAdapterMap should unmodifiable #11801

Merged
merged 23 commits into from
Mar 7, 2024

Conversation

floor07
Copy link
Contributor

@floor07 floor07 commented Mar 6, 2024

PageHandlerAdapterFactory, handlerAdapters,handlerAdapterMap should unmodifiable

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 67.80%. Comparing base (b7c3905) to head (a68e215).
Report is 172 commits behind head on develop.

Files with missing lines Patch % Lines
...persistence/handler/PageHandlerAdapterFactory.java 0.00% 14 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #11801      +/-   ##
=============================================
- Coverage      67.80%   67.80%   -0.01%     
+ Complexity      8892     8891       -1     
=============================================
  Files           1237     1237              
  Lines          40443    40440       -3     
  Branches        4286     4285       -1     
=============================================
- Hits           27424    27421       -3     
  Misses         11046    11046              
  Partials        1973     1973              
Files with missing lines Coverage Δ
...persistence/handler/PageHandlerAdapterFactory.java 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7c3905...a68e215. Read the comment docs.

@KomachiSion KomachiSion added the kind/enhancement Category issues or prs related to enhancement. label Mar 7, 2024
@KomachiSion KomachiSion added this to the 2.4.0 milestone Mar 7, 2024
@KomachiSion KomachiSion merged commit c2aa515 into alibaba:develop Mar 7, 2024
7 checks passed
@KomachiSion KomachiSion modified the milestones: 2.4.0, 2.3.2 Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants