Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format check on client labels #11903

Merged

Conversation

shiyiyue1102
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 65.00000% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 68.40%. Comparing base (6dc0a21) to head (cfbfea5).
Report is 6 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #11903      +/-   ##
=============================================
+ Coverage      68.31%   68.40%   +0.09%     
- Complexity      8976     8995      +19     
=============================================
  Files           1239     1239              
  Lines          40560    40599      +39     
  Branches        4311     4321      +10     
=============================================
+ Hits           27709    27773      +64     
+ Misses         10861    10827      -34     
- Partials        1990     1999       +9     
Files Coverage Δ
...cos/common/labels/impl/DefaultLabelsCollector.java 68.08% <100.00%> (+3.79%) ⬆️
...om/alibaba/nacos/common/utils/ConnLabelsUtils.java 71.42% <92.85%> (+0.97%) ⬆️
...mon/labels/impl/DefaultLabelsCollectorManager.java 71.69% <38.09%> (-22.06%) ⬇️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dc0a21...cfbfea5. Read the comment docs.

@KomachiSion KomachiSion closed this Apr 1, 2024
@KomachiSion KomachiSion reopened this Apr 1, 2024
@shiyiyue1102 shiyiyue1102 merged commit 5fcef22 into alibaba:develop Apr 1, 2024
13 checks passed
@shiyiyue1102 shiyiyue1102 deleted the develop-labelsformatcheck branch April 1, 2024 06:55
@KomachiSion KomachiSion added this to the 2.3.2 milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants