Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #11879] Fix Navigator clipboard api needs a secure context (https) #11942

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

hnyyghk
Copy link
Contributor

@hnyyghk hnyyghk commented Apr 10, 2024

fix Navigator clipboard api needs a secure context (https)

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix #11879

Brief changelog

console-ui/src/components/Copy/index.jsx

fix Navigator clipboard api needs a secure context (https)
refer to https://stackoverflow.com/questions/51805395/navigator-clipboard-is-undefined

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@KomachiSion KomachiSion added area/Nacos console Related to Nacos consle kind/bug Category issues or prs related to bug. labels Apr 11, 2024
@KomachiSion KomachiSion merged commit fb59708 into alibaba:develop Apr 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Nacos console Related to Nacos consle kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

浏览器禁止了非安全域的 navigator.clipboard 对象
2 participants