Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#11975] clean code , remove unused dependency javatuple #11976

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

shalk
Copy link
Contributor

@shalk shalk commented Apr 18, 2024

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix #11975

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@shalk shalk force-pushed the clean-not-used-dep-javatuple branch from 73ee0b4 to b17676f Compare April 18, 2024 08:47
chuntaojun
chuntaojun previously approved these changes Apr 19, 2024
@KomachiSion
Copy link
Collaborator

测试用例已修复, 请同步develop分支后重新提交

@shalk
Copy link
Contributor Author

shalk commented Apr 24, 2024

@KomachiSion done

@KomachiSion KomachiSion added kind/code quality dependencies Pull requests that update a dependency file labels Apr 24, 2024
@KomachiSion KomachiSion added this to the 2.4.0 milestone Apr 24, 2024
@KomachiSion KomachiSion merged commit de10c07 into alibaba:develop Apr 24, 2024
12 of 13 checks passed
syshenyao pushed a commit to syshenyao/nacos that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file kind/code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[clean code] dependency javatuple is unused
3 participants