[ISSUE #11994]修复HttpRequestInstanceBuilderTest出现的空指针问题，优化SnowFlakeInstanceIdGenerator初始化流程 #11995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in HttpRequestInstanceBuilderTest
|
|
KomachiSion
previously approved these changes
Apr 22, 2024
|
Error: /home/runner/work/nacos/nacos/naming/src/main/java/com/alibaba/nacos/naming/pojo/instance/SnowFlakeInstanceIdGenerator.java:37:33: Name 'lock' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'. [ConstantName] Please fix code style problem. |
|
@KomachiSion I have fixed it. |
llzcx
changed the title
The-Gamer-01
approved these changes
Apr 22, 2024
| @@ -54,6 +56,7 @@ public class HttpRequestInstanceBuilderTest { | |||
| @BeforeClass | |||
| public static void setUpBeforeClass() { | |||
| NacosServiceLoader.load(InstanceExtensionHandler.class); | |||
| EnvUtil.setEnvironment(new StandardEnvironment()); | |||
KomachiSion
approved these changes
Apr 22, 2024
|
Continuous Integration/CI (Ubuntu latest, 8) results：
Can the local test pass, but Continuous Integration/CI (Ubuntu latest, 8) cannot? |
|
No problem, I will fix it in next PR. |
This was referenced Apr 23, 2024
syshenyao
pushed a commit
to syshenyao/nacos
that referenced
this pull request
Apr 25, 2024
…lakeInstanceIdGenerator初始化流程 (alibaba#11995) * [ISSUE alibaba#11994] fix: Initialize EnvUtil's variable environment in HttpRequestInstanceBuilderTest * refactor: Optimize the initialization process of SnowFlakeInstanceIdGenerator * refactor: optimize the initialization process of SnowFlakeInstanceIdGenerator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
fix unit test bug.
解决SnowFlakeInstanceIdGenerator类加载时强依赖workerId的初始化过程。
Brief changelog
@BeforeClass增加EnvUtil.setEnvironment(new StandardEnvironment());
改变WorkerId的加载方式。通过SnowFlakeInstanceIdGenerator静态代码块加载->在generateInstanceId通过双检锁保证加载一次
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.