Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #12130] add metadata as labels in prometheus http sd #12144

Merged
merged 2 commits into from
Jun 3, 2024
Merged

[ISSUE #12130] add metadata as labels in prometheus http sd #12144

merged 2 commits into from
Jun 3, 2024

Conversation

Kurok1
Copy link
Contributor

@Kurok1 Kurok1 commented May 29, 2024

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

add feature for #12130

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

KomachiSion
KomachiSion previously approved these changes May 31, 2024
@KomachiSion
Copy link
Collaborator

CI can't pass please fix them。

@Kurok1
Copy link
Contributor Author

Kurok1 commented May 31, 2024

I fixed it

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.74%. Comparing base (bc039bc) to head (6f92dd3).
Report is 18 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12144      +/-   ##
=============================================
- Coverage      68.75%   68.74%   -0.01%     
- Complexity      9128     9140      +12     
=============================================
  Files           1252     1254       +2     
  Lines          40907    40956      +49     
  Branches        4340     4344       +4     
=============================================
+ Hits           28125    28156      +31     
- Misses         10766    10784      +18     
  Partials        2016     2016              
Files Coverage Δ
...libaba/nacos/prometheus/utils/PrometheusUtils.java 94.73% <100.00%> (+1.40%) ⬆️

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc039bc...6f92dd3. Read the comment docs.

@KomachiSion KomachiSion added this to the 2.4.0 milestone Jun 3, 2024
@KomachiSion KomachiSion merged commit da78aee into alibaba:develop Jun 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants