Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do some refactor for naming notify event. #12167

Merged

Conversation

KomachiSion
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

For #10374

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 93.93939% with 4 lines in your changes missing coverage. Please review.

Project coverage is 68.80%. Comparing base (7cdf224) to head (92257b2).
Report is 67 commits behind head on develop.

Files Patch % Lines
...a/nacos/client/naming/backups/FailoverReactor.java 57.14% 1 Missing and 2 partials ⚠️
...libaba/nacos/client/naming/NacosNamingService.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12167      +/-   ##
=============================================
+ Coverage      68.78%   68.80%   +0.02%     
- Complexity      9221     9229       +8     
=============================================
  Files           1263     1264       +1     
  Lines          41177    41183       +6     
  Branches        4360     4361       +1     
=============================================
+ Hits           28322    28336      +14     
+ Misses         10815    10810       -5     
+ Partials        2040     2037       -3     
Files Coverage Δ
...aba/nacos/client/naming/cache/InstancesDiffer.java 100.00% <100.00%> (ø)
...a/nacos/client/naming/cache/ServiceInfoHolder.java 93.84% <100.00%> (+2.54%) ⬆️
...acos/client/naming/event/InstancesChangeEvent.java 100.00% <ø> (ø)
.../client/naming/selector/NamingListenerInvoker.java 77.77% <100.00%> (+6.34%) ⬆️
...libaba/nacos/client/naming/NacosNamingService.java 88.32% <0.00%> (-0.46%) ⬇️
...a/nacos/client/naming/backups/FailoverReactor.java 69.47% <57.14%> (-3.94%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cdf224...92257b2. Read the comment docs.

@KomachiSion KomachiSion merged commit 07d92ff into alibaba:develop Jun 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants