Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #12185]fix: use nacos properties in CacheDirUtil #12186

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

shalk
Copy link
Contributor

@shalk shalk commented Jun 6, 2024

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix #12185

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@shalk shalk changed the title fix: use nacos properties in CacheDirUtil [ISSUE #12185]fix: use nacos properties in CacheDirUtil Jun 6, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.77%. Comparing base (04f9b86) to head (aaf4f35).
Report is 16 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12186      +/-   ##
=============================================
+ Coverage      68.74%   68.77%   +0.03%     
- Complexity      9140     9228      +88     
=============================================
  Files           1254     1264      +10     
  Lines          40952    41183     +231     
  Branches        4344     4361      +17     
=============================================
+ Hits           28151    28325     +174     
- Misses         10787    10820      +33     
- Partials        2014     2038      +24     
Files Coverage Δ
...libaba/nacos/client/naming/utils/CacheDirUtil.java 91.66% <100.00%> (ø)

... and 24 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04f9b86...aaf4f35. Read the comment docs.

@KomachiSion KomachiSion merged commit 7590a4e into alibaba:develop Jun 12, 2024
7 checks passed
@KomachiSion KomachiSion added area/Client Related to Nacos Client SDK kind/enhancement Category issues or prs related to enhancement. labels Jun 12, 2024
@KomachiSion KomachiSion added this to the 2.4.0 milestone Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Client Related to Nacos Client SDK kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix CacheDirUtil read properties
3 participants