Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #12207] fix disk failover datasource not keep status #12188

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

shalk
Copy link
Contributor

@shalk shalk commented Jun 6, 2024

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix #12207

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.80%. Comparing base (04f9b86) to head (ad3a727).
Report is 16 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12188      +/-   ##
=============================================
+ Coverage      68.74%   68.80%   +0.06%     
- Complexity      9140     9229      +89     
=============================================
  Files           1254     1264      +10     
  Lines          40952    41188     +236     
  Branches        4344     4361      +17     
=============================================
+ Hits           28151    28338     +187     
- Misses         10787    10813      +26     
- Partials        2014     2037      +23     
Files Coverage Δ
...ing/backups/datasource/DiskFailoverDataSource.java 78.68% <72.72%> (-3.46%) ⬇️

... and 24 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04f9b86...ad3a727. Read the comment docs.

@KomachiSion
Copy link
Collaborator

has switchParams keep the status?

@KomachiSion
Copy link
Collaborator

Suggest submit issue first to describe this problem.

@shalk shalk changed the title fix disk failover datasource not keep status [ISSUE #12207] fix disk failover datasource not keep status Jun 12, 2024
@shalk
Copy link
Contributor Author

shalk commented Jun 12, 2024

has switchParams keep the status?

No, it is not.

When lastmodify is not changed, but if (lastModifiedMillis < modified) make FailoverFileReader return false

@KomachiSion
Copy link
Collaborator

KomachiSion commented Jun 17, 2024

has switchParams keep the status?

No, it is not.

When lastmodify is not changed, but if (lastModifiedMillis < modified) make FailoverFileReader return false

If lastmodify is not changed, the FailoverFileReader should be false, which means there is no need to reload file i think.

@KomachiSion KomachiSion merged commit b8d13e0 into alibaba:develop Jun 26, 2024
7 checks passed
@KomachiSion KomachiSion added kind/bug Category issues or prs related to bug. area/Client Related to Nacos Client SDK labels Jun 26, 2024
@KomachiSion KomachiSion added this to the 2.4.0 milestone Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Client Related to Nacos Client SDK kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]disk failover datasource not keep status
3 participants