Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #12282]Fix the issue where monitoring data cannot be found thr… #12315

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

HMYDK
Copy link
Contributor

@HMYDK HMYDK commented Jul 5, 2024

#12282 Fix the issue where monitoring data cannot be found through the IP dimension in the ListeningQuery

…und through the IP dimension in the ListeningQuery
@KomachiSion
Copy link
Collaborator

@HMYDK Can you add some unit test for this?

@HMYDK
Copy link
Contributor Author

HMYDK commented Jul 15, 2024

@HMYDK Can you add some unit test for this?

  • getCollectSampleResultByIp(String ip, int sampleTime)已经有测试用例了。
    • ListenerControllerTest.testGetAllSubClientConfigByIp()
  • 新加的runConfigListenerByIpCollectionJob中请求的路径/watcherConfigs也已经有测试用例了。
    • CommunicationControllerTest.testGetSubClientConfigByIp()

@shiyiyue1102 shiyiyue1102 merged commit 6c05ad5 into alibaba:develop Jul 15, 2024
7 checks passed
lowezheng added a commit to lowezheng/nacos that referenced this pull request Jul 24, 2024
…apexsoft

* commit '197795a854992d3f88824e4cdde34c61d8f56cf4': (225 commits)
  Fix alibaba#12395, use request context replace session depend. (alibaba#12398)
  Revert "Add an id primary key column to both the roles and permissions tables.(mysql-schema.sql) (alibaba#12206)" (alibaba#12396)
  Upgrade to 2.4.0 (alibaba#12384)
  Develop support ram info switch (alibaba#12382)
  Close derby ops api default. (alibaba#12372)
  Upgrade grpc to 1.64.2 (alibaba#12369)
  fix(alibaba#12333): fixed auth Plugin resource parser can't parser v2 config openAPI namespaceId. (alibaba#12336)
  Adjust integration tests for common modules in the core module to comply with checkstyle. (alibaba#12349)
  [IT]Adjust integration tests for cluster,code,smoke modules in the core module to comply with checkstyle. (alibaba#12350)
  fix [ISSUE alibaba#12323] , using the project's logback packagingData configuration instead of logback-nacos.xml's packagingData configuration (alibaba#12360)
  Remove the accessToken from the URL. (alibaba#12353)
  feat(alibaba#12355): Record the cost of ConfigDump in Prometheus. (alibaba#12356)
  [IT]Adjust core module auth integration tests to meet checkstyle requirements. (alibaba#12368)
  [ISSUE alibaba#12282]Fix the issue where monitoring data cannot be found through the IP dimension in the ListeningQuery (alibaba#12315)
  Adjust integration tests for ability, base, and client modules in the core module to comply with checkstyle. (alibaba#12335)
  Develop refactor request context (alibaba#12331)
  fix unexpect exception from NetworkInterface.ifUp (alibaba#12325)
  fix(alibaba#12231): When inserting and updating configurations in the database, the time-related field values need to be set using the time obtained from the database's built-in time function. (alibaba#12244)
  add some UT for default auth plugin (alibaba#12318)
  [ISSUE alibaba#12219] 修复nacos-client中config的ServerListManager解析endpoint失败问题 (alibaba#12220)
  ...

# Conflicts:
#	plugin-default-impl/nacos-default-auth-plugin/src/main/java/com/alibaba/nacos/plugin/auth/impl/persistence/ExternalPermissionPersistServiceImpl.java
#	pom.xml
@HMYDK HMYDK deleted the develop-#12282 branch July 31, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants