Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Remove KvStorage and ConsistencyService. #12489

Merged
merged 4 commits into from
Aug 15, 2024

Conversation

KomachiSion
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@KomachiSion KomachiSion added this to the 2.4.1 milestone Aug 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 17.14286% with 29 lines in your changes missing coverage. Please review.

Project coverage is 69.42%. Comparing base (5d8d81a) to head (163e4de).
Report is 3 commits behind head on develop.

Files Patch % Lines
...a/com/alibaba/nacos/naming/misc/SwitchManager.java 0.00% 29 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12489      +/-   ##
=============================================
+ Coverage      69.40%   69.42%   +0.01%     
- Complexity      9429     9450      +21     
=============================================
  Files           1281     1282       +1     
  Lines          41484    41558      +74     
  Branches        4387     4397      +10     
=============================================
+ Hits           28794    28852      +58     
- Misses         10620    10627       +7     
- Partials        2070     2079       +9     
Files Coverage Δ
...baba/nacos/naming/cluster/ServerStatusManager.java 100.00% <100.00%> (ø)
...a/com/alibaba/nacos/naming/misc/SwitchManager.java 0.00% <0.00%> (ø)

... and 28 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d8d81a...163e4de. Read the comment docs.

@KomachiSion KomachiSion merged commit bbed5a4 into alibaba:develop Aug 15, 2024
7 checks passed
@xiaoyang1012
Copy link

这个提交是修复 Nacos Jraft 文件读写漏洞 问题的吗

@xaitx
Copy link

xaitx commented Aug 28, 2024

这个提交是修复 Nacos Jraft 文件读写漏洞 问题的吗

所以看出来了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants