Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Enhance derby sql to support limit sql. #12490

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

KomachiSion
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@KomachiSion KomachiSion added the kind/enhancement Category issues or prs related to enhancement. label Aug 15, 2024
@KomachiSion KomachiSion added this to the 2.4.1 milestone Aug 15, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 69.38%. Comparing base (c56c415) to head (977ac76).

Files Patch % Lines
...re/persistence/DistributedDatabaseOperateImpl.java 0.00% 4 Missing ⚠️
...mbedded/operate/StandaloneDatabaseOperateImpl.java 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12490      +/-   ##
=============================================
- Coverage      69.38%   69.38%   -0.01%     
+ Complexity      9427     9425       -2     
=============================================
  Files           1281     1281              
  Lines          41488    41488              
  Branches        4388     4388              
=============================================
- Hits           28788    28787       -1     
+ Misses         10632    10631       -1     
- Partials        2068     2070       +2     
Files Coverage Δ
...re/persistence/DistributedDatabaseOperateImpl.java 0.00% <0.00%> (ø)
...mbedded/operate/StandaloneDatabaseOperateImpl.java 23.80% <0.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c56c415...977ac76. Read the comment docs.

@KomachiSion KomachiSion merged commit 7133411 into alibaba:develop Aug 15, 2024
7 checks passed
@KomachiSion KomachiSion deleted the develop-limit-derby-sql branch August 15, 2024 08:44
@xiaoyang1012
Copy link

这个提交就是修复 Nacos的任意文件读写漏洞 问题的吗?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants