Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issues#12551] maven-shade打包了其他依赖的模块化描述文件 #12660

Closed
wants to merge 1 commit into from

Conversation

luxiao0000
Copy link
Contributor

maven-shade-plugin插件打包时会把gson里的模块化描述文件带过来,导致nacos-client错误的使用了gson的模块化描述文件

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


xiao.lu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.66%. Comparing base (3a9003b) to head (be8703a).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12660      +/-   ##
=============================================
- Coverage      69.70%   69.66%   -0.04%     
  Complexity      9431     9431              
=============================================
  Files           1275     1275              
  Lines          41232    41236       +4     
  Branches        4374     4375       +1     
=============================================
- Hits           28740    28728      -12     
- Misses         10412    10428      +16     
  Partials        2080     2080              

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12f474e...be8703a. Read the comment docs.

@KomachiSion
Copy link
Collaborator

Please sign cla first,

from the cla bot response, your commit is not relative your github id, it will not be relative to your sign cla. I think you can close this PR and branch, and create an new branch and commit this change again with new git config with github id and github email.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants