Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc invoke source refactor #12716

Merged

Conversation

shiyiyue1102
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 76.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 69.64%. Comparing base (3a9003b) to head (7e2a7e8).
Report is 11 commits behind head on develop.

Files with missing lines Patch % Lines
...baba/nacos/core/remote/RequestHandlerRegistry.java 63.63% 2 Missing and 2 partials ⚠️
...alibaba/nacos/core/remote/grpc/BaseGrpcServer.java 84.61% 2 Missing ⚠️
...baba/nacos/core/remote/grpc/GrpcClusterServer.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12716      +/-   ##
=============================================
- Coverage      69.70%   69.64%   -0.07%     
+ Complexity      9431     9426       -5     
=============================================
  Files           1275     1275              
  Lines          41232    41265      +33     
  Branches        4374     4376       +2     
=============================================
- Hits           28740    28737       -3     
- Misses         10412    10444      +32     
- Partials        2080     2084       +4     
Files with missing lines Coverage Δ
...fig/server/controller/ClientMetricsController.java 91.66% <100.00%> (+0.59%) ⬆️
.../remote/ConfigChangeClusterSyncRequestHandler.java 100.00% <ø> (ø)
...nacos/core/cluster/remote/MemberReportHandler.java 0.00% <ø> (ø)
...re/remote/core/ServerLoaderInfoRequestHandler.java 100.00% <ø> (ø)
...core/remote/core/ServerReloaderRequestHandler.java 100.00% <ø> (ø)
.../alibaba/nacos/core/remote/grpc/GrpcSdkServer.java 73.52% <100.00%> (+0.80%) ⬆️
...g/remote/rpc/handler/DistroDataRequestHandler.java 69.69% <ø> (ø)
...baba/nacos/core/remote/grpc/GrpcClusterServer.java 69.44% <0.00%> (-1.99%) ⬇️
...alibaba/nacos/core/remote/grpc/BaseGrpcServer.java 74.68% <84.61%> (+4.53%) ⬆️
...baba/nacos/core/remote/RequestHandlerRegistry.java 64.86% <63.63%> (-0.52%) ⬇️

... and 38 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91987b0...7e2a7e8. Read the comment docs.

@KomachiSion KomachiSion added this to the 2.5.0 milestone Oct 11, 2024
@KomachiSion KomachiSion merged commit d712ee5 into alibaba:develop Oct 11, 2024
7 checks passed
@KomachiSion KomachiSion modified the milestones: 2.5.0, 2.4.3 Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants