Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the database driver version of Mysql to 8 # 3036 #2993 #1868 #3060

Merged
merged 6 commits into from
Jun 15, 2020

Conversation

paderlol
Copy link
Collaborator

@paderlol paderlol commented Jun 13, 2020

What is the purpose of the change

Upgrade the database driver version of Mysql to 8

Brief changelog

  1. Upgrade the database driver version of Mysql to 8
  2. Optimize data source configuration code

#3036
#2993
#2676
#1868

Verifying this change

  1. Upgrade the database driver version of Mysql to 8
  2. Optimize data source configuration code

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@CLAassistant
Copy link

CLAassistant commented Jun 13, 2020

CLA assistant check
All committers have signed the CLA.

@paderlol paderlol requested a review from chuntaojun June 13, 2020 13:18
@paderlol paderlol requested a review from chuntaojun June 13, 2020 14:11
chuntaojun
chuntaojun previously approved these changes Jun 13, 2020
@chuntaojun chuntaojun added this to the 1.3.1 milestone Jun 14, 2020
@paderlol paderlol requested a review from chuntaojun June 14, 2020 10:00
chuntaojun
chuntaojun previously approved these changes Jun 14, 2020
Copy link
Collaborator

@TsingLiang TsingLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@TsingLiang TsingLiang merged commit 1323de0 into alibaba:develop Jun 15, 2020
@KomachiSion KomachiSion added dependencies Pull requests that update a dependency file area/Nacos Core labels Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Nacos Core dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants