Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#3324] fix http client close bug #3333

Merged
merged 2 commits into from
Jul 15, 2020
Merged

[ISSUE#3324] fix http client close bug #3333

merged 2 commits into from
Jul 15, 2020

Conversation

Maijh97
Copy link
Collaborator

@Maijh97 Maijh97 commented Jul 15, 2020

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix: #3324

Brief changelog

Move http client close method to NamingProxy.shutdown()

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

# Conflicts:
#	common/src/main/java/com/alibaba/nacos/common/http/HttpClientBeanHolder.java
@Maijh97 Maijh97 changed the title [ISSUE##3324] fix http client close bug [ISSUE#3324] fix http client close bug Jul 15, 2020
@KomachiSion KomachiSion merged commit 0163d2d into alibaba:develop Jul 15, 2020
@KomachiSion KomachiSion added the kind/bug Category issues or prs related to bug. label Jul 15, 2020
@KomachiSion KomachiSion added this to the 1.3.2 milestone Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.3.1 注销服务异常
2 participants