[ISSUE #3224]nacos-client module http client replace #3348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please help to review this pr, thanks @KomachiSion |
…o refactor_config_http_client
KomachiSion
reviewed
Jul 16, 2020
| @@ -226,54 +222,46 @@ private boolean publishConfigInner(String tenant, String dataId, String group, S | |||
| cr.setContent(content); | |||
| configFilterChainManager.doFilter(cr, null); | |||
| content = cr.getContent(); | |||
|
|
|||
There was a problem hiding this comment.
do not change intend please
| } | ||
|
|
||
| HttpResult result = null; | ||
|
|
There was a problem hiding this comment.
do not change intend please
| return false; | ||
| } | ||
|
|
||
| if (HttpURLConnection.HTTP_OK == result.code) { | ||
|
|
There was a problem hiding this comment.
do not change intend please
| String ts = String.valueOf(System.currentTimeMillis()); | ||
| String token = MD5Utils.md5Hex(ts + ParamUtil.getAppKey(), Constants.ENCODE); | ||
|
|
||
| header.addParam(Constants.CLIENT_APPNAME_HEADER, ParamUtil.getAppName()); |
There was a problem hiding this comment.
Where are these logic from?
There was a problem hiding this comment.
This logic comes from the old HttpSimpleClient#setHeaders method.
| @@ -30,45 +28,42 @@ | |||
|
|
|||
| public static final Logger LOGGER = LogUtils.logger(EnvUtil.class); | |||
|
|
|||
| public static void setSelfEnv(Map<String, List<String>> headers) { | |||
| public static void setSelfEnv(Header headers) { | |||
There was a problem hiding this comment.
Is these method refactor correctly? I see the input is come from httpclient.
There was a problem hiding this comment.
Correct, the original input is also from the http client, this method is called by the ServerListManager#getApacheServerList method.
…modifying the original logic code
KomachiSion
previously approved these changes
Jul 17, 2020
# Conflicts: # client/src/main/java/com/alibaba/nacos/client/config/impl/ServerListManager.java
KomachiSion
approved these changes
Jul 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
#3224
Brief changelog
Replace the http client in the config package of the
nacos-clientmoduleVerifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.