Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3388]Reset nacos roles, permissions during reloading role info from database #3442

Merged
merged 2 commits into from
Jul 27, 2020

Conversation

yanjunnf
Copy link
Contributor

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

#3388

Brief changelog

We should rest nacos roles, permissions when reloading role info from database. For some scenarios, some roles and permission may be removed by administrator.

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@yanjunnf yanjunnf changed the title Reset nacos roles, permissions during reloading role info from database [#3388]Reset nacos roles, permissions during reloading role info from database Jul 25, 2020
Copy link
Collaborator

@chuntaojun chuntaojun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

使用volatile修饰,确保线程间可见,或者使用AtomicReference

@yanjunnf
Copy link
Contributor Author

Already added.

@yanjunnf
Copy link
Contributor Author

yanjunnf commented Jul 25, 2020

Checked the failed build log below, looks like this error is nothing to do with code changes.

Tests run: 33, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 222.362 sec <<< FAILURE! - in com.alibaba.nacos.test.config.ConfigAPI_CITCase
nacos_addListener_1(com.alibaba.nacos.test.config.ConfigAPI_CITCase) Time elapsed: 25.031 sec <<< ERROR!
org.junit.runners.model.TestTimedOutException: test timed out after 25000 milliseconds
at app//com.alibaba.nacos.test.config.ConfigAPI_CITCase.nacos_addListener_1(ConfigAPI_CITCase.java:372)

@KomachiSion KomachiSion added area/Nacos console Related to Nacos consle kind/bug Category issues or prs related to bug. labels Jul 27, 2020
@KomachiSion KomachiSion added this to the 1.3.2 milestone Jul 27, 2020
@KomachiSion KomachiSion merged commit 377f778 into alibaba:develop Jul 27, 2020
lancediarmuid pushed a commit to lancediarmuid/nacos that referenced this pull request Jul 27, 2020
…fo from database (alibaba#3442)

* Reset nacos roles, permissions during reloading role info from database

* Add volatile to guarantee visibility in threads
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Nacos console Related to Nacos consle kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants