[ISSUE-#3855] Provided a feature to view version comparisons in the configDetails page #3988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feature-3855
|
|
KomachiSion
approved these changes
Oct 14, 2020
|
@jzhishu Can you add some unit test or integration test for your changes? |
KomachiSion
added
kind/enhancement
Ok, I'll add the test case later |
KomachiSion
requested changes
Oct 15, 2020
| */ | ||
| @GetMapping | ||
| public ConfigHistoryInfo getConfigHistoryInfo(HttpServletRequest request, HttpServletResponse response, | ||
| @RequestParam("nid") Long nid, ModelMap modelMap) { | ||
| return persistService.detailConfigHistory(nid); | ||
| } | ||
|
|
||
| /** | ||
| * Query previous config history information. |
There was a problem hiding this comment.
Please add @since 1.4.0
KomachiSion
previously approved these changes
Oct 15, 2020
loadchange
previously approved these changes
Oct 15, 2020
|
Can you add some pictures to show the final form |
|
|
KomachiSion
approved these changes
Oct 19, 2020
zilongTong
pushed a commit
to zilongTong/nacos
that referenced
this pull request
Oct 19, 2020
…n the configDetails page (alibaba#3988) * add detail previous config history api * modify the previous config history url * modify log description * 详情页面添加“历史对比”按钮，点击可打开对比面板 * 点击“历史对比”按钮，获取上一版本数据 * 在查看历史对比的时候 不显示revert按钮 * append doc info * Add unit tests for ISSUE#3855 * Add the previous updates to main.js and main.css Co-authored-by: 赵延 <[email protected]>
WesleyOne
pushed a commit
to WesleyOne/nacos
that referenced
this pull request
Oct 20, 2020
…n the configDetails page (alibaba#3988) * add detail previous config history api * modify the previous config history url * modify log description * 详情页面添加“历史对比”按钮，点击可打开对比面板 * 点击“历史对比”按钮，获取上一版本数据 * 在查看历史对比的时候 不显示revert按钮 * append doc info * Add unit tests for ISSUE#3855 * Add the previous updates to main.js and main.css Co-authored-by: 赵延 <[email protected]>
loveincode
added a commit
to Framework-Source-Code/nacos
that referenced
this pull request
Oct 21, 2020
* 'develop' of github.com:alibaba/nacos: (678 commits) Fix integration test error Fix unit test error in ci For checkStyle Modify the startup script custom configuration first default configuration (alibaba#4021) Revert "Naming module Raft protocol migration" [ISSUE alibaba#3904] feature - operate instance's metadata alonely (alibaba#3912) For alibaba#3710#, Fix special characters cannot be used in Metadata (alibaba#4019) [ISSUE-alibaba#3855] Provided a feature to view version comparisons in the configDetails page (alibaba#3988) Refactor dispatch task execute (alibaba#3995) Revert "for alibaba#3621 (alibaba#3668)" (alibaba#3999) Naming module Raft protocol migration (alibaba#3989) refactor: code refactor [ISSUE alibaba#3576] [Enhancement] Adding the destroy lifecycle method on NamingMaintainService (alibaba#3985) Fix issue 2866 (alibaba#3984) For alibaba#3384, Fix member extend info do not update error. (alibaba#3982) Fix#3973 (alibaba#3974) Move remove listener logic to ServiceManager Move remove listener logic to ServiceManager 1.fix unit test can't pass (alibaba#3956) [ISSUE alibaba#3909] add domain's judgement (alibaba#3913) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
#3855
Brief changelog