Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3548] The srcUser fills with username when auth is disabled (console case) #5566

Merged
merged 7 commits into from
May 10, 2021
Merged

[ISSUE #3548] The srcUser fills with username when auth is disabled (console case) #5566

merged 7 commits into from
May 10, 2021

Conversation

plusmancn
Copy link
Contributor

@plusmancn plusmancn commented May 3, 2021

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Fix #3548
Fix #5485

see: #3548 (comment)

Brief changelog

  • The srcUser fills with username when auth is disabled (console case)
  • Fix operator missing in HistoryDetail Page
  • Add source IP field in HistoryDetail Page
  • Translate comments in UserController.java from Chinese to English
  • Trim trailing whitespace as required by .editorconfig

Verifying this change

  • Maybe you should reload the cache of the web browser
  • You must re-login to console
  • Setting nacos.core.auth.enabled=false
  • Check it!

image

image

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

Copy link
Collaborator

@KeRan213539 KeRan213539 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why format so many files?
Please refer to this document to set up code style: https:/alibaba/nacos/blob/develop/style/codeStyle.md

@plusmancn
Copy link
Contributor Author

Why format so many files?
Please refer to this document to set up code style: https:/alibaba/nacos/blob/develop/style/codeStyle.md

@KeRan213539 Because of this line in .editorconfig of Nacos, IDEA will trim all trailing whitespace on save.

trim_trailing_whitespace = true

@plusmancn
Copy link
Contributor Author

@KeRan213539 I have fixed the code style problem. By the way, I have also fixed that the back button of HistoryDetail.js won't work.

@plusmancn plusmancn requested a review from KeRan213539 May 6, 2021 12:58
@KomachiSion
Copy link
Collaborator

I have some question:

  1. If user do not fill this operator, whether this change will cause exception?
  2. If user publish config by nacos-client, and no open auth without client login, whether this change will cause exception?

@plusmancn
Copy link
Contributor Author

I have some question:

  1. If user do not fill this operator, whether this change will cause exception?
  2. If user publish config by nacos-client, and no open auth without client login, whether this change will cause exception?

@KomachiSion it will be null as before

@KomachiSion
Copy link
Collaborator

Sorry, there are some conflict with other PR I merged, please fix it.

@plusmancn
Copy link
Contributor Author

plusmancn commented May 10, 2021

Sorry, there are some conflict with other PR I merged, please fix it.

@KomachiSion I has solved the conflict with develop branch.

@KomachiSion KomachiSion merged commit 7e57b90 into alibaba:develop May 10, 2021
@KomachiSion KomachiSion added kind/enhancement Category issues or prs related to enhancement. area/Nacos console Related to Nacos consle labels May 10, 2021
@KomachiSion KomachiSion added this to the 1.4.3 milestone May 10, 2021
@KomachiSion KomachiSion modified the milestones: 1.4.3, 2.0.2 Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Nacos console Related to Nacos consle kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The srcUser field is always null How to get operators when disabled auth.
4 participants