catch exception when register self to cluster. #7564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
li-xiao-shuang
previously approved these changes
Jan 6, 2022
| } | ||
| Loggers.RAFT.warn("Failed to join the cluster, retry..."); | ||
| } catch (Exception e) { | ||
| Loggers.RAFT.warn("Failed to join the cluster, retry...", e); |
There was a problem hiding this comment.
catch 到异常 应该打error日志比较好
li-xiao-shuang
approved these changes
Jan 7, 2022
zrlw
added a commit
to zrlw/nacos
that referenced
this pull request
Jan 9, 2022
zrlw
added a commit
to zrlw/nacos
that referenced
this pull request
Feb 21, 2022
KomachiSion
pushed a commit
that referenced
this pull request
Feb 24, 2022
CherishCai
pushed a commit
to CherishCai/nacos
that referenced
this pull request
Apr 12, 2022
* apply PR alibaba#7564 from develop to catch exception when register self * apply PR alibaba#6987 from develop to fix response success * apply PR alibaba#6575 to read from leader when readIndex timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
catch exception when register self to cluster.