[ISSUE #7869 #7750]fix bug in permissions management module, such as redundant 'nacos,' when change password #8189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
chuntaojun
approved these changes
Apr 17, 2022
KomachiSion
approved these changes
Apr 18, 2022
KomachiSion
requested changes
Apr 18, 2022
jefferson-chern
commented
Apr 18, 2022
| @@ -161,11 +161,11 @@ private boolean hasPermission(String username, HttpServletRequest request) { | |||
| if (!authConfigs.isAuthEnabled()) { | |||
| return true; | |||
| } | |||
| if (Objects.isNull(request.getAttribute(RequestUtil.NACOS_USER_KEY))) { | |||
| if (Objects.isNull(request.getSession().getAttribute(RequestUtil.NACOS_USER_KEY))) { | |||
There was a problem hiding this comment.
this commit is that when the authentication switch is turned on, there is no way to change the password(forbidden), because the user information has been saved in the session, but the previous code was obtained directly from reqeust.
…fix alibaba#7869 and alibaba#7750. * get user info from session in UserController. * simply some code in UserController.
jefferson-chern
force-pushed
the
v1.x-develop-fix-7869
branch
from
a05a36a
to
65c2019
Compare
done |
KomachiSion
approved these changes
Apr 22, 2022
|
where to find this build? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not create a Pull Request without creating an issue first.
fix and close #7869 and #7750
What is the purpose of the change
there are no redundant 'nacos,' string when change password, add user and so on.
Brief changelog
delete
usernameparam when request from console to backend, because the user info saved in session, see PR #7804.Verifying this change