Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#8479]Fix the problem that some singleton classes construction m… #8508

Merged
merged 1 commit into from
Jun 7, 2022
Merged

[ISSUE#8479]Fix the problem that some singleton classes construction m… #8508

merged 1 commit into from
Jun 7, 2022

Conversation

MRGUOKING
Copy link
Contributor

…ethod not private

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

For #8479

Brief changelog

change two construction methodes of singleton class that below pulgin module from public to private

@CLAassistant
Copy link

CLAassistant commented Jun 3, 2022

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

Merging #8508 (fc2e747) into develop (d8238de) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #8508      +/-   ##
=============================================
+ Coverage      41.10%   41.23%   +0.12%     
- Complexity      4383     4393      +10     
=============================================
  Files            876      876              
  Lines          31862    31862              
  Branches        3709     3709              
=============================================
+ Hits           13096    13137      +41     
+ Misses         17453    17407      -46     
- Partials        1313     1318       +5     
Impacted Files Coverage Δ
...acos/plugin/auth/spi/server/AuthPluginManager.java 52.63% <100.00%> (ø)
...cos/plugin/encryption/EncryptionPluginManager.java 54.16% <100.00%> (ø)
.../naming/push/v2/NamingSubscriberServiceV2Impl.java 74.41% <0.00%> (-11.63%) ⬇️
...ing/core/v2/index/ClientServiceIndexesManager.java 63.93% <0.00%> (-9.84%) ⬇️
...a/nacos/client/naming/backups/FailoverReactor.java 30.83% <0.00%> (-9.17%) ⬇️
...com/alibaba/nacos/naming/core/v2/pojo/Service.java 72.41% <0.00%> (-6.90%) ⬇️
...cos/naming/core/v2/event/service/ServiceEvent.java 93.33% <0.00%> (-6.67%) ⬇️
...baba/nacos/client/auth/ram/identify/StsConfig.java 66.66% <0.00%> (-5.13%) ⬇️
...s/client/naming/core/ServiceInfoUpdateService.java 64.93% <0.00%> (-2.60%) ⬇️
...a/nacos/core/remote/control/TpsMonitorManager.java 54.54% <0.00%> (-1.30%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8238de...fc2e747. Read the comment docs.

@KomachiSion KomachiSion merged commit 9b077d4 into alibaba:develop Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants