Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly specify spring-boot-maven-plugin version same as spring-boot #8596

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

liqipeng
Copy link
Contributor

Explicitly specify spring-boot-maven-plugin version same as spring-boot by pluginManagement.

@codecov-commenter
Copy link

Codecov Report

Merging #8596 (b9c88b9) into develop (e5cfd23) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #8596      +/-   ##
=============================================
+ Coverage      41.20%   41.25%   +0.04%     
- Complexity      4428     4430       +2     
=============================================
  Files            882      882              
  Lines          32107    32107              
  Branches        3718     3718              
=============================================
+ Hits           13231    13245      +14     
+ Misses         17549    17531      -18     
- Partials        1327     1331       +4     
Impacted Files Coverage Δ
...alibaba/nacos/core/remote/control/TpsRecorder.java 74.32% <0.00%> (-1.36%) ⬇️
...s/naming/consistency/persistent/raft/RaftCore.java 9.92% <0.00%> (+0.19%) ⬆️
...ient/naming/remote/http/NamingHttpClientProxy.java 80.36% <0.00%> (+0.91%) ⬆️
.../nacos/naming/healthcheck/ClientBeatCheckTask.java 31.81% <0.00%> (+1.51%) ⬆️
...a/nacos/core/remote/control/TpsMonitorManager.java 54.54% <0.00%> (+3.24%) ⬆️
.../alibaba/nacos/client/naming/beat/BeatReactor.java 52.87% <0.00%> (+6.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5cfd23...b9c88b9. Read the comment docs.

@KomachiSion
Copy link
Collaborator

What‘s the reason add spring-boot-maven-plugin?

@liqipeng
Copy link
Contributor Author

What‘s the reason add spring-boot-maven-plugin?

@KomachiSion
spring-boot-maven-plugin is used in console, address, config module, and no version specified.
This PR is not to add spring-boot-maven-plugin plugin to parent pom, but add spring-boot-maven-plugin to pluginManagement to make the version specified.

I meet a similar error describe in https://www.jianshu.com/p/878a8b62e70f when I build nacos in a differenct PC.
So I think it is better to specify a version to keep version fixed with spring-boot version.

@KomachiSion KomachiSion merged commit 2a4c281 into alibaba:develop Jun 24, 2022
@KomachiSion KomachiSion added the dependencies Pull requests that update a dependency file label Jun 24, 2022
@KomachiSion KomachiSion added this to the 2.1.1 milestone Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants